]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
[media] si2168: Bounds check firmware
authorLaura Abbott <labbott@fedoraproject.org>
Wed, 30 Sep 2015 00:10:09 +0000 (21:10 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Thu, 22 Oct 2015 17:48:25 +0000 (15:48 -0200)
commit47810b4341ac9d2f558894bc5995e6fa2a1298f9
treeaae0581364c14f1252d1287fc96fb65e74f8a6dc
parenta828d72df216c36e9c40b6c24dc4b17b6f7b5a76
[media] si2168: Bounds check firmware

When reading the firmware and sending commands, the length must
be bounds checked to avoid overrunning the size of the command
buffer and smashing the stack if the firmware is not in the expected
format:

si2168 11-0064: found a 'Silicon Labs Si2168-B40'
si2168 11-0064: downloading firmware from file 'dvb-demod-si2168-b40-01.fw'
si2168 11-0064: firmware download failed -95
Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in: ffffffffa085708f

Add the proper check.

Cc: stable@kernel.org
Reported-by: Stuart Auchterlonie <sauchter@redhat.com>
Reviewed-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Laura Abbott <labbott@fedoraproject.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/dvb-frontends/si2168.c