]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
powerpc/powernv: Avoid re-registration of imc debugfs directory
authorAnju T Sudhakar <anju@linux.vnet.ibm.com>
Wed, 27 Nov 2019 07:20:35 +0000 (12:50 +0530)
committerMichael Ellerman <mpe@ellerman.id.au>
Thu, 5 Dec 2019 06:06:23 +0000 (17:06 +1100)
commit48e626ac85b43cc589dd1b3b8004f7f85f03544d
tree25cfc59e9d8ef45af72002e7c5b3c9099b4152fc
parent551003fff7235ce935bc1fefb72d12b63a408bd0
powerpc/powernv: Avoid re-registration of imc debugfs directory

export_imc_mode_and_cmd() function which creates the debugfs interface
for imc-mode and imc-command, is invoked when each nest pmu units is
registered.

When the first nest pmu unit is registered, export_imc_mode_and_cmd()
creates 'imc' directory under `/debug/powerpc/`. In the subsequent
invocations debugfs_create_dir() function returns, since the directory
already exists.

The recent commit <c33d442328f55> (debugfs: make error message a bit
more verbose), throws a warning if we try to invoke
`debugfs_create_dir()` with an already existing directory name.

Address this warning by making the debugfs directory registration in
the opal_imc_counters_probe() function, i.e invoke
export_imc_mode_and_cmd() function from the probe function.

Signed-off-by: Anju T Sudhakar <anju@linux.vnet.ibm.com>
Tested-by: Nageswara R Sastry <nasastry@in.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20191127072035.4283-1-anju@linux.vnet.ibm.com
arch/powerpc/platforms/powernv/opal-imc.c