]> git.proxmox.com Git - mirror_qemu.git/commit
error: make Error **errp const where it is appropriate
authorVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Thu, 5 Dec 2019 17:46:17 +0000 (20:46 +0300)
committerMarkus Armbruster <armbru@redhat.com>
Wed, 18 Dec 2019 07:36:16 +0000 (08:36 +0100)
commit49fbc7236dd203f9c6afa87454f603a9236a0b3b
tree850cd538066053acd9954beac48ddbb1586673f4
parent33c9642f657193bc478c96f08434ae746397b70e
error: make Error **errp const where it is appropriate

Mostly, Error ** is for returning error from the function, so the
callee sets it. However these three functions get already filled errp
parameter. They don't change the pointer itself, only change the
internal state of referenced Error object. So we can make it
Error *const * errp, to stress the behavior. It will also help
coccinelle script (in future) to distinguish such cases from common
errp usage.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20191205174635.18758-4-vsementsov@virtuozzo.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
[Commit message typo fixed]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
include/qapi/error.h
util/error.c