]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
vhost_net: correctly check tx avail during rx busy polling
authorJason Wang <jasowang@redhat.com>
Tue, 5 Sep 2017 01:22:05 +0000 (09:22 +0800)
committerSeth Forshee <seth.forshee@canonical.com>
Wed, 20 Sep 2017 12:23:44 +0000 (07:23 -0500)
commit4ab0b8d31d3f507d46e042e9094d06274c1c30a4
tree63a61fadecfd792fad8db83c68ba64b4e26c1b4b
parent5895b8deddaca78913fca90f90b2e1e3ece947db
vhost_net: correctly check tx avail during rx busy polling

BugLink: http://bugs.launchpad.net/bugs/1718412
[ Upstream commit 8b949bef9172ca69d918e93509a4ecb03d0355e0 ]

We check tx avail through vhost_enable_notify() in the past which is
wrong since it only checks whether or not guest has filled more
available buffer since last avail idx synchronization which was just
done by vhost_vq_avail_empty() before. What we really want is checking
pending buffers in the avail ring. Fix this by calling
vhost_vq_avail_empty() instead.

This issue could be noticed by doing netperf TCP_RR benchmark as
client from guest (but not host). With this fix, TCP_RR from guest to
localhost restores from 1375.91 trans per sec to 55235.28 trans per
sec on my laptop (Intel(R) Core(TM) i7-5600U CPU @ 2.60GHz).

Fixes: 030881372460 ("vhost_net: basic polling support")
Signed-off-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
drivers/vhost/net.c