]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
powerpc/44x/fsp2: add missing of_node_put
authorBixuan Cui <cuibixuan@linux.alibaba.com>
Thu, 28 Oct 2021 07:28:22 +0000 (15:28 +0800)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Thu, 13 Jan 2022 17:42:34 +0000 (18:42 +0100)
commit4ac6389ecf2d284f434ea3f18c1dc2ae84055848
tree6083c7870475200ca78cc893af050133ed3c08a3
parent01f2284749f82caaf50277f41cc02cac82b4ff22
powerpc/44x/fsp2: add missing of_node_put

BugLink: https://bugs.launchpad.net/bugs/1953387
[ Upstream commit 290fe8aa69ef5c51c778c0bb33f8ef0181c769f5 ]

Early exits from for_each_compatible_node() should decrement the
node reference counter.  Reported by Coccinelle:

./arch/powerpc/platforms/44x/fsp2.c:206:1-25: WARNING: Function
"for_each_compatible_node" should have of_node_put() before return
around line 218.

Fixes: 7813043e1bbc ("powerpc/44x/fsp2: Add irq error handlers")
Signed-off-by: Bixuan Cui <cuibixuan@linux.alibaba.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/1635406102-88719-1-git-send-email-cuibixuan@linux.alibaba.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
arch/powerpc/platforms/44x/fsp2.c