]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
drm/amdgpu: fix multiple memory leaks in acp_hw_init
authorNavid Emamdoost <navid.emamdoost@gmail.com>
Wed, 2 Oct 2019 03:46:07 +0000 (22:46 -0500)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 12 Nov 2019 17:46:17 +0000 (18:46 +0100)
commit4ac92a6944dd8c8712240a3558d0b5c8cbce6396
tree8def3df41528b258ad51376e3ce06413d07a5251
parent855035aa9bcbf1b9cabbfbb9dceccf0748383c62
drm/amdgpu: fix multiple memory leaks in acp_hw_init

BugLink: https://bugs.launchpad.net/bugs/1850456
[ Upstream commit 57be09c6e8747bf48704136d9e3f92bfb93f5725 ]

In acp_hw_init there are some allocations that needs to be released in
case of failure:

1- adev->acp.acp_genpd should be released if any allocation attemp for
adev->acp.acp_cell, adev->acp.acp_res or i2s_pdata fails.
2- all of those allocations should be released if
mfd_add_hotplug_devices or pm_genpd_add_device fail.
3- Release is needed in case of time out values expire.

Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Connor Kuehl <connor.kuehl@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c