]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
Revert "NFSv4: Handle the special Linux file open access mode"
authorChenXiaoSong <chenxiaosong2@huawei.com>
Tue, 29 Mar 2022 11:32:07 +0000 (19:32 +0800)
committerStefan Bader <stefan.bader@canonical.com>
Wed, 27 Apr 2022 09:59:29 +0000 (11:59 +0200)
commit4b4b6ea5afba51ca0c2634e3a2bd6332caf07395
tree83fcae65efd18840dd0ac450208a63835074963f
parent02302672f52b8703471fa777e62b5e51213d80e7
Revert "NFSv4: Handle the special Linux file open access mode"

BugLink: https://bugs.launchpad.net/bugs/1969107
[ Upstream commit ab0fc21bc7105b54bafd85bd8b82742f9e68898a ]

This reverts commit 44942b4e457beda00981f616402a1a791e8c616e.

After secondly opening a file with O_ACCMODE|O_DIRECT flags,
nfs4_valid_open_stateid() will dereference NULL nfs4_state when lseek().

Reproducer:
  1. mount -t nfs -o vers=4.2 $server_ip:/ /mnt/
  2. fd = open("/mnt/file", O_ACCMODE|O_DIRECT|O_CREAT)
  3. close(fd)
  4. fd = open("/mnt/file", O_ACCMODE|O_DIRECT)
  5. lseek(fd)

Reported-by: Lyu Tao <tao.lyu@epfl.ch>
Signed-off-by: ChenXiaoSong <chenxiaosong2@huawei.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
(cherry picked from commit 9f0c217469e84e71f7423bce64527c0b56bf9228)
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
fs/nfs/inode.c
fs/nfs/nfs4file.c