]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
pinctrl: samsung: Fix device node refcount leaks in S3C24xx wakeup controller init
authorKrzysztof Kozlowski <krzk@kernel.org>
Mon, 5 Aug 2019 16:27:08 +0000 (18:27 +0200)
committerMarcelo Henrique Cerri <marcelo.cerri@canonical.com>
Fri, 17 Jan 2020 17:22:45 +0000 (14:22 -0300)
commit4ba74eb288fe079e6da78e6bdda62bce0f903ec7
tree127a7aaf414c22c99dc4058ceb1148cd6c2ee476
parent40e58ca5f5824680811a19276d817cf33cdf6ba6
pinctrl: samsung: Fix device node refcount leaks in S3C24xx wakeup controller init

BugLink: https://bugs.launchpad.net/bugs/1857158
commit 6fbbcb050802d6ea109f387e961b1dbcc3a80c96 upstream.

In s3c24xx_eint_init() the for_each_child_of_node() loop is used with a
break to find a matching child node.  Although each iteration of
for_each_child_of_node puts the previous node, but early exit from loop
misses it.  This leads to leak of device node.

Cc: <stable@vger.kernel.org>
Fixes: af99a7507469 ("pinctrl: Add pinctrl-s3c24xx driver")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/pinctrl/samsung/pinctrl-s3c24xx.c