]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
net: lapbether: fix issue of dev reference count leakage in lapbeth_device_event()
authorZhengchao Shao <shaozhengchao@huawei.com>
Thu, 3 Nov 2022 09:05:37 +0000 (17:05 +0800)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Wed, 14 Dec 2022 12:59:03 +0000 (13:59 +0100)
commit4bd2cfa80188f52592d3b351a7f7b97839afcc24
treed0edf133e31c15dbaabc468337c45007932e09f3
parent36f7a17649b47ba81aa6d0f41634fd22bfb281c3
net: lapbether: fix issue of dev reference count leakage in lapbeth_device_event()

[ Upstream commit 531705a765493655472c993627106e19f7e5a6d2 ]

When following tests are performed, it will cause dev reference counting
leakage.
a)ip link add bond2 type bond mode balance-rr
b)ip link set bond2 up
c)ifenslave -f bond2 rose1
d)ip link del bond2

When new bond device is created, the default type of the bond device is
ether. And the bond device is up, lapbeth_device_event() receives the
message and creates a new lapbeth device. In this case, the reference
count value of dev is hold once. But after "ifenslave -f bond2 rose1"
command is executed, the type of the bond device is changed to rose. When
the bond device is unregistered, lapbeth_device_event() will not put the
dev reference count.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
(cherry picked from commit f59adebb8c28fe6738650f87660860c5a7180f05)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
drivers/net/wan/lapbether.c