]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
drm/virtio: document drm_dev_set_unique workaround
authorEmil Velikov <emil.velikov@collabora.com>
Wed, 24 Oct 2018 14:42:52 +0000 (15:42 +0100)
committerEmil Velikov <emil.l.velikov@gmail.com>
Thu, 25 Oct 2018 12:25:58 +0000 (13:25 +0100)
commit4bdbd5f0eeeebaeefb2b664c233adc846c8dc413
treeaa21006993e69411aa7dd0dad8565d18174117c4
parentf08877e79485897aa1093514daa668cc5b728418
drm/virtio: document drm_dev_set_unique workaround

A while back we removed it, yet that lead to regressions. At some later
point, I've attempted to remove it again without fully grasping the
unique (pun intended) situation that virtio is in.

Add a bulky comment to document why the call should stay as-is, for the
next person who's around.

As a Tl;Dr: virtio sits on top of struct virtio_device, which confuses
dev_is_pci(), wrong info gets sent to userspace and X doesn't start.
Driver needs to explicitly call drm_dev_set_unique() to keep it working.

v2: Fix handful of typos (Laszlo)

Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20181024144252.16518-1-emil.l.velikov@gmail.com
drivers/gpu/drm/virtio/virtgpu_drm_bus.c