]> git.proxmox.com Git - mirror_qemu.git/commit
audio/audio: fix video playback slowdown with spiceaudio
authorVolker Rümelin <vr_qemu@t-online.de>
Sun, 20 Sep 2020 17:17:22 +0000 (19:17 +0200)
committerGerd Hoffmann <kraxel@redhat.com>
Wed, 23 Sep 2020 06:19:42 +0000 (08:19 +0200)
commit4c3356f96557e848f0323772f9502d60817682dc
tree90ecf10ad23a3203aef9dd929fa07ec59b6ab1e7
parentd4b70fa4ede25734d2ff76503c735e6fcee6cfda
audio/audio: fix video playback slowdown with spiceaudio

This patch allows the audio backends get_buffer_out() functions
to drop audio data and mitigates a bug reported on the qemu-devel
mailing list.

https://lists.nongnu.org/archive/html/qemu-devel/2020-09/msg03832.html

The new rules for the variables buf and size returned by
get_buffer_out() are:
size == 0: Downstream playback buffer is full. Retry later.
size > 0, buf != NULL: Copy size bytes to buf for playback.
size > 0, buf == NULL: Drop size bytes.

The audio playback rate with spiceaudio for the no audio case is
too fast, but that's what we had before commit fb35c2cec5
"audio/dsound: fix invalid parameters error". The complete fix
comes with the next patch.

Reported-by: Qi Zhou <atmgnd@outlook.com>
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Message-id: 20200920171729.15861-2-vr_qemu@t-online.de
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
audio/audio.c