]> git.proxmox.com Git - mirror_qemu.git/commit
9pfs: make Error **errp const where it is appropriate
authorVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Thu, 5 Dec 2019 17:46:22 +0000 (20:46 +0300)
committerMarkus Armbruster <armbru@redhat.com>
Wed, 18 Dec 2019 07:43:19 +0000 (08:43 +0100)
commit4c5ec47e639f8dbcede5b343b6d373127758e844
treedfaad8c33b063f3ac3fabe6195bed33d83c74a70
parent0c115681a5194a53a4b373c4ff6d8b42ddd23b55
9pfs: make Error **errp const where it is appropriate

Mostly, Error ** is for returning error from the function, so the
callee sets it. However error_append_security_model_hint and
error_append_socket_sockfd_hint get already filled errp
parameter. They don't change the pointer itself, only change the
internal state of referenced Error object. So we can make it Error
*const * errp, to stress the behavior. It will also help coccinelle
script (in future) to distinguish such cases from common errp usage.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Acked-by: Greg Kurz <groug@kaod.org>
Message-Id: <20191205174635.18758-9-vsementsov@virtuozzo.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
[Commit message replaced]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
hw/9pfs/9p-local.c
hw/9pfs/9p-proxy.c