]> git.proxmox.com Git - mirror_qemu.git/commit
hw/mips/itu: Pass SAAR using QOM link property
authorPhilippe Mathieu-Daudé <philmd@linaro.org>
Thu, 2 Feb 2023 13:22:42 +0000 (14:22 +0100)
committerPhilippe Mathieu-Daudé <philmd@linaro.org>
Tue, 7 Mar 2023 23:37:48 +0000 (00:37 +0100)
commit4c921e3fb2a9f53cbc97318487844b48ad3781f8
treea4e513c1c38a511721388604def27383c8566494
parent10997f2d1ded7616d33276cdc2a3e37b9ce2154d
hw/mips/itu: Pass SAAR using QOM link property

QOM objects shouldn't access each other internals fields
except using the QOM API.

mips_cps_realize() instantiates a TYPE_MIPS_ITU object, and
directly sets the 'saar' pointer:

   if (saar_present) {
       s->itu.saar = &env->CP0_SAAR;
   }

In order to avoid that, pass the MIPS_CPU object via a QOM
link property, and set the 'saar' pointer in mips_itu_realize().

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
Message-Id: <20230203113650.78146-10-philmd@linaro.org>
hw/mips/cps.c
hw/misc/mips_itu.c
include/hw/misc/mips_itu.h