]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
net: ethernet: ti: cpsw: fix ASSERT_RTNL() warning during resume
authorGrygorii Strashko <grygorii.strashko@ti.com>
Tue, 29 Nov 2016 22:27:03 +0000 (16:27 -0600)
committerDavid S. Miller <davem@davemloft.net>
Wed, 30 Nov 2016 19:59:08 +0000 (14:59 -0500)
commit4ccfd6383a1a4838ed034120f00d02dbdc681d6f
tree7f7b59fcaa50c984ae5397a18920fc0a722592be
parente2d2afe15ed452f91797a80dbc0a17838ba03ed4
net: ethernet: ti: cpsw: fix ASSERT_RTNL() warning during resume

netif_set_real_num_tx/rx_queues() are required to be called with rtnl_lock
taken, otherwise ASSERT_RTNL() warning will be triggered - which happens
now during System resume from suspend:
cpsw_resume()
|- cpsw_ndo_open()
  |- netif_set_real_num_tx/rx_queues()
     |- ASSERT_RTNL();

Hence, fix it by surrounding cpsw_ndo_open() by rtnl_lock/unlock() calls.

Cc: Dave Gerlach <d-gerlach@ti.com>
Cc: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Fixes: commit e05107e6b747 ("net: ethernet: ti: cpsw: add multi queue support")
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Reviewed-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Tested-by: Dave Gerlach <d-gerlach@ti.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ti/cpsw.c