]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
coredump: Ensure proper size of sparse core files
authorDave Kleikamp <dave.kleikamp@oracle.com>
Wed, 11 Jan 2017 19:25:00 +0000 (13:25 -0600)
committerAl Viro <viro@zeniv.linux.org.uk>
Sun, 15 Jan 2017 00:32:40 +0000 (19:32 -0500)
commit4d22c75d4c7b5c5f4bd31054f09103ee490878fd
treea58ff1b3bb440af13026891f6ccb38d36fffcb4c
parenta12f1ae61c489076a9aeb90bddca7722bf330df3
coredump: Ensure proper size of sparse core files

If the last section of a core file ends with an unmapped or zero page,
the size of the file does not correspond with the last dump_skip() call.
gdb complains that the file is truncated and can be confusing to users.

After all of the vma sections are written, make sure that the file size
is no smaller than the current file position.

This problem can be demonstrated with gdb's bigcore testcase on the
sparc architecture.

Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/binfmt_elf.c
fs/coredump.c
include/linux/coredump.h