]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
netfilter: seqadj: re-load tcp header pointer after possible head reallocation
authorFlorian Westphal <fw@strlen.de>
Wed, 5 Dec 2018 13:12:19 +0000 (14:12 +0100)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 14 Aug 2019 09:18:49 +0000 (11:18 +0200)
commit4d418075605a356d6a86f635ef74ccef170fd546
tree5e8f1df41f56461313b0d6a31f6e5cfb0903ef37
parent980d742e6d4df4f180b80e3225964c9ecc6e0668
netfilter: seqadj: re-load tcp header pointer after possible head reallocation

BugLink: https://bugs.launchpad.net/bugs/1837477
[ Upstream commit 530aad77010b81526586dfc09130ec875cd084e4 ]

When adjusting sack block sequence numbers, skb_make_writable() gets
called to make sure tcp options are all in the linear area, and buffer
is not shared.

This can cause tcp header pointer to get reallocated, so we must
reaload it to avoid memory corruption.

This bug pre-dates git history.

Reported-by: Neel Mehta <nmehta@google.com>
Reported-by: Shane Huntley <shuntley@google.com>
Reported-by: Heather Adkins <argv@google.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
net/netfilter/nf_conntrack_seqadj.c