]> git.proxmox.com Git - mirror_qemu.git/commit
blockdev: fix missed target unref for drive-backup
authorJohn Snow <jsnow@redhat.com>
Mon, 13 May 2019 15:06:38 +0000 (11:06 -0400)
committerKevin Wolf <kwolf@redhat.com>
Tue, 4 Jun 2019 13:20:41 +0000 (15:20 +0200)
commit4da26f138db06c9c6d7199d42bd3c2be552cb956
tree510ec888d533c4524ac0d5612bf4c0b0c7b96113
parentac6fb43eae1f5029b51e0a3d975fe2111cc8b976
blockdev: fix missed target unref for drive-backup

If the bitmap can't be used for whatever reason, we skip putting down
the reference. Fix that.

In practice, this means that if you attempt to gracefully exit QEMU
after a backup command being rejected, bdrv_close_all will fail and
tell you some unpleasant things via assert().

Reported-by: aihua liang <aliang@redhat.com>
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1703916
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
blockdev.c