]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
scsi: qedi: Fix error codes in qedi_alloc_global_queues()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 10 Aug 2021 08:47:53 +0000 (11:47 +0300)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 16 Aug 2021 17:27:57 +0000 (13:27 -0400)
commit4dbe57d46d54a847875fa33e7d05877bb341585e
tree8608cc2fff8340e648fd78255a7e3191d3d839a2
parentd1f6581a6796c4e9fd8a4a24e8b77463d18f0df1
scsi: qedi: Fix error codes in qedi_alloc_global_queues()

This function had some left over code that returned 1 on error instead
negative error codes.  Convert everything to use negative error codes.  The
caller treats all non-zero returns the same so this does not affect run
time.

A couple places set "rc" instead of "status" so those error paths ended up
returning success by mistake.  Get rid of the "rc" variable and use
"status" everywhere.

Remove the bogus "status = 0" initialization, as a future proofing measure
so the compiler will warn about uninitialized error codes.

Link: https://lore.kernel.org/r/20210810084753.GD23810@kili
Fixes: ace7f46ba5fd ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver framework.")
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qedi/qedi_main.c