]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
f2fs: Eliminate usage of uninitialized_var() macro
authorJason Yan <yanaijie@huawei.com>
Mon, 15 Jun 2020 08:51:32 +0000 (16:51 +0800)
committerKees Cook <keescook@chromium.org>
Thu, 16 Jul 2020 19:32:26 +0000 (12:32 -0700)
commit4df7a75f690a2651d766cc45d442824b955f9e4b
tree7eb42c7c0afa8c349699cd6b585059acd4079d9c
parent4a2b958b1fb31144a48d261c98885b1e02e1af0e
f2fs: Eliminate usage of uninitialized_var() macro

This is an effort to eliminate the uninitialized_var() macro[1].

The use of this macro is the wrong solution because it forces off ANY
analysis by the compiler for a given variable. It even masks "unused
variable" warnings.

Quoted from Linus[2]:

"It's a horrible thing to use, in that it adds extra cruft to the
source code, and then shuts up a compiler warning (even the _reliable_
warnings from gcc)."

Fix it by remove this variable since it is not needed at all.

[1] https://github.com/KSPP/linux/issues/81
[2] https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yVJu65TpLgN_ybYNv0VEOKA@mail.gmail.com/

Suggested-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Link: https://lore.kernel.org/r/20200615085132.166470-1-yanaijie@huawei.com
Signed-off-by: Kees Cook <keescook@chromium.org>
fs/f2fs/data.c