]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
seq_buf: Fix overflow in seq_buf_putmem_hex()
authorYun Zhou <yun.zhou@windriver.com>
Sat, 26 Jun 2021 03:21:55 +0000 (11:21 +0800)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 13 Aug 2021 07:46:59 +0000 (09:46 +0200)
commit4e4b2ed57c9e7464f0e41dde3c199319dc7e3108
tree2071e4684828977d7a1f26994f408932c65d9eda
parentb7c509d997d193096da5383df4d48ec077ece2dd
seq_buf: Fix overflow in seq_buf_putmem_hex()

BugLink: https://bugs.launchpad.net/bugs/1938713
commit d3b16034a24a112bb83aeb669ac5b9b01f744bb7 upstream.

There's two variables being increased in that loop (i and j), and i
follows the raw data, and j follows what is being written into the buffer.
We should compare 'i' to MAX_MEMHEX_BYTES or compare 'j' to HEX_CHARS.
Otherwise, if 'j' goes bigger than HEX_CHARS, it will overflow the
destination buffer.

Link: https://lore.kernel.org/lkml/20210625122453.5e2fe304@oasis.local.home/
Link: https://lkml.kernel.org/r/20210626032156.47889-1-yun.zhou@windriver.com
Cc: stable@vger.kernel.org
Fixes: 5e3ca0ec76fce ("ftrace: introduce the "hex" output method")
Signed-off-by: Yun Zhou <yun.zhou@windriver.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
lib/seq_buf.c