]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
ASoC: intel: atom: Stop advertising non working S24LE support
authorHans de Goede <hdegoede@redhat.com>
Wed, 24 Mar 2021 13:27:10 +0000 (14:27 +0100)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 7 May 2021 07:53:17 +0000 (09:53 +0200)
commit4e5a74db5b1f1c927588233a5cee2502fe57ee61
tree3f90dad6820b3a0b0b11a09646e78847778131a2
parent2ffa03710e2d3592637dd649c91c7a7651c7a4e4
ASoC: intel: atom: Stop advertising non working S24LE support

BugLink: https://bugs.launchpad.net/bugs/1926368
commit aa65bacdb70e549a81de03ec72338e1047842883 upstream.

The SST firmware's media and deep-buffer inputs are hardcoded to
S16LE, the corresponding DAIs don't have a hw_params callback and
their prepare callback also does not take the format into account.

So far the advertising of non working S24LE support has not caused
issues because pulseaudio defaults to S16LE, but changing pulse-audio's
config to use S24LE will result in broken sound.

Pipewire is replacing pulse now and pipewire prefers S24LE over S16LE
when available, causing the problem of the broken S24LE support to
come to the surface now.

Cc: stable@vger.kernel.org
BugLink: https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/866
Fixes: 098c2cd281409 ("ASoC: Intel: Atom: add 24-bit support for media playback and capture")
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20210324132711.216152-2-hdegoede@redhat.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
sound/soc/intel/atom/sst-mfld-platform-pcm.c