]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
af_key: fix buffer overread in parse_exthdrs()
authorEric Biggers <ebiggers@google.com>
Sat, 30 Dec 2017 00:15:23 +0000 (18:15 -0600)
committerSteffen Klassert <steffen.klassert@secunet.com>
Sat, 30 Dec 2017 08:52:08 +0000 (09:52 +0100)
commit4e765b4972af7b07adcb1feb16e7a525ce1f6b28
tree6aca6a9e625a700198c17a89da9190c7d36f0d2f
parent06b335cb51af018d5feeff5dd4fd53847ddb675a
af_key: fix buffer overread in parse_exthdrs()

If a message sent to a PF_KEY socket ended with an incomplete extension
header (fewer than 4 bytes remaining), then parse_exthdrs() read past
the end of the message, into uninitialized memory.  Fix it by returning
-EINVAL in this case.

Reproducer:

#include <linux/pfkeyv2.h>
#include <sys/socket.h>
#include <unistd.h>

int main()
{
int sock = socket(PF_KEY, SOCK_RAW, PF_KEY_V2);
char buf[17] = { 0 };
struct sadb_msg *msg = (void *)buf;

msg->sadb_msg_version = PF_KEY_V2;
msg->sadb_msg_type = SADB_DELETE;
msg->sadb_msg_len = 2;

write(sock, buf, 17);
}

Cc: stable@vger.kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
net/key/af_key.c