]> git.proxmox.com Git - qemu.git/commit
usb: controllers do not need to check for babble themselves
authorHans de Goede <hdegoede@redhat.com>
Fri, 17 Aug 2012 09:39:16 +0000 (11:39 +0200)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Fri, 12 Oct 2012 02:44:13 +0000 (21:44 -0500)
commit4ebbf3229acac66085ca467d79cac38befebc28d
tree4bab6c604160e5a1b22d08d17ed5d920428bfe07
parentb5701820f8fb1c52d26da6bcedb0729a869a9b55
usb: controllers do not need to check for babble themselves

If an (emulated) usb-device tries to write more data to a packet then
its iov len, this will trigger an assert in usb_packet_copy(), and if
a driver somehow circumvents that check and writes more data to the
iov then there is space, we have a much bigger problem then not correctly
reporting babble to the guest.

In practice babble will only happen with (real) redirected devices, and there
both the usb-host os and the qemu usb-device code already check for it.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
(cherry picked from commit 45b339b18c660eb85af2ba25bfcaed5469660d77)

Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
hw/usb/hcd-ehci.c
hw/usb/hcd-uhci.c