]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
perf tests: No need to set attr.sample_freq in the perf time to TSC test
authorArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 7 Jan 2016 12:54:56 +0000 (09:54 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 7 Jan 2016 14:26:54 +0000 (11:26 -0300)
commit4f4ba0e6afac4b181471f5f12bd87294bd8807f6
treed4959a087385ba51b81482882e631289b4972833
parent84530920de3c6ccb92c6661da784f6cdb66d3304
perf tests: No need to set attr.sample_freq in the perf time to TSC test

We were asking for a 4kHz sample_freq, making the test fail needlessly
when the system reduced /proc/sys/kernel/perf_event_max_sample_rate
below that.

In this test we only look at the PERF_SAMPLE_TIME fields in PERF_RECORD_
meta events, no need to set sample_freq.

Thanks to Namhyung for suggesting that max_sample_rate could be the
reason for the test failure, seeing the 'perf test -vv' output I sent.

Before:

  # echo 1000 > /proc/sys/kernel/perf_event_max_sample_rate
  # perf test TSC
  45: Test converting perf time to TSC   : FAILED!

After:

  # perf test TSC
  45: Test converting perf time to TSC   : Ok
  # cat /proc/sys/kernel/perf_event_max_sample_rate
  1000

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-lcob05qhawkuvsyuu9g1fld5@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/arch/x86/tests/perf-time-to-tsc.c