]> git.proxmox.com Git - mirror_iproute2.git/commit
f_flower: don't set TCA_FLOWER_KEY_ETH_TYPE for "protocol all"
authorBenjamin LaHaise <benjamin.lahaise@netronome.com>
Fri, 20 Jan 2017 19:07:38 +0000 (14:07 -0500)
committerStephen Hemminger <stephen@networkplumber.org>
Mon, 30 Jan 2017 04:23:58 +0000 (20:23 -0800)
commit4f7d406f5dc89229d8aec8b723015c06db343e17
treef6c0960ef2e834bf8644cb66e0190058042238de
parent11f2c753155b1cdcc3dd62769183b462ad85ef43
f_flower: don't set TCA_FLOWER_KEY_ETH_TYPE for "protocol all"

v2 - update to address changes in 00697ca19ae3e1118f2af82c3b41ac4335fe918b.

When using the tc flower filter, rules marked with "protocol all" do not
actually match all packets.  This is due to a bug in f_flower.c that passes
in ETH_P_ALL in the TCA_FLOWER_KEY_ETH_TYPE attribute when adding a rule.
Fix this by omitting TCA_FLOWER_KEY_ETH_TYPE if the protocol is set to
ETH_P_ALL.

Fixes: 488b41d020fb ("tc: flower no need to specify the ethertype")
Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: Benjamin LaHaise <benjamin.lahaise@netronome.com>
Signed-off-by: Benjamin LaHaise <bcrl@kvack.org>
Reviewed-by: Roi Dayan <roid@mellanox.com>
tc/f_flower.c