]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
igc: AF_XDP zero-copy metadata adjust breaks SKBs on XDP_PASS
authorJesper Dangaard Brouer <brouer@redhat.com>
Mon, 15 Nov 2021 20:36:25 +0000 (21:36 +0100)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Tue, 30 Nov 2021 16:19:25 +0000 (08:19 -0800)
commit4fa8fcd3440101dbacf4fae91de69877ef751977
tree01a2c966cf6da7ca0b6da6d16d6b682b2aeefc41
parent196073f9c44be0b4758ead11e51bc2875f98df29
igc: AF_XDP zero-copy metadata adjust breaks SKBs on XDP_PASS

Driver already implicitly supports XDP metadata access in AF_XDP
zero-copy mode, as xsk_buff_pool's xp_alloc() naturally set xdp_buff
data_meta equal data.

This works fine for XDP and AF_XDP, but if a BPF-prog adjust via
bpf_xdp_adjust_meta() and choose to call XDP_PASS, then igc function
igc_construct_skb_zc() will construct an invalid SKB packet. The
function correctly include the xdp->data_meta area in the memcpy, but
forgot to pull header to take metasize into account.

Fixes: fc9df2a0b520 ("igc: Enable RX via AF_XDP zero-copy")
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Tested-by: Nechama Kraus <nechamax.kraus@linux.intel.com>
Acked-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/igc/igc_main.c