]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
decnet: dn_rtmsg: Improve input length sanitization in dnrmg_receive_user_skb
authorMateusz Jurczyk <mjurczyk@google.com>
Wed, 7 Jun 2017 14:14:29 +0000 (16:14 +0200)
committerSeth Forshee <seth.forshee@canonical.com>
Wed, 5 Jul 2017 16:36:20 +0000 (11:36 -0500)
commit5075d748048f4376df344d09b701682b58be7b32
tree65f7cbc2fd782324d7195e57186097c0c7667e91
parentfb3d482455f33c243fe9f2bdcc4c8b042f397c37
decnet: dn_rtmsg: Improve input length sanitization in dnrmg_receive_user_skb

BugLink: http://bugs.launchpad.net/bugs/1702515
[ Upstream commit dd0da17b209ed91f39872766634ca967c170ada1 ]

Verify that the length of the socket buffer is sufficient to cover the
nlmsghdr structure before accessing the nlh->nlmsg_len field for further
input sanitization. If the client only supplies 1-3 bytes of data in
sk_buff, then nlh->nlmsg_len remains partially uninitialized and
contains leftover memory from the corresponding kernel allocation.
Operating on such data may result in indeterminate evaluation of the
nlmsg_len < sizeof(*nlh) expression.

The bug was discovered by a runtime instrumentation designed to detect
use of uninitialized memory in the kernel. The patch prevents this and
other similar tools (e.g. KMSAN) from flagging this behavior in the future.

Signed-off-by: Mateusz Jurczyk <mjurczyk@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
net/decnet/netfilter/dn_rtmsg.c