]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
phy: cpcap-usb: Fix error path when no host driver is loaded
authorTony Lindgren <tony@atomide.com>
Fri, 20 Dec 2019 10:51:40 +0000 (16:21 +0530)
committerKhalid Elmously <khalid.elmously@canonical.com>
Fri, 14 Feb 2020 06:00:53 +0000 (01:00 -0500)
commit507b1c0e24a8479245c22858e1665239a3786cc0
treee70b26677125a5ae335cc40e6ced0a080138d010
parent0c6e43018b9a3aba58c509145ce458d34df448ed
phy: cpcap-usb: Fix error path when no host driver is loaded

BugLink: https://bugs.launchpad.net/bugs/1862227
commit 4acb0200ab2b07843e3ef5599add3454c7440f03 upstream.

If musb_mailbox() returns an error, we must still continue to finish
configuring the phy.

Otherwise the phy state may end up only half initialized, and this can
cause the debug serial console to stop working. And this will happen if the
usb driver musb controller is not loaded.

Let's fix the issue by adding helper for cpcap_usb_try_musb_mailbox().

Fixes: 6d6ce40f63af ("phy: cpcap-usb: Add CPCAP PMIC USB support")
Cc: Merlijn Wajer <merlijn@wizzup.org>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Sebastian Reichel <sre@kernel.org>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/phy/motorola/phy-cpcap-usb.c