]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
kernel/module: Hide vermagic header file from general use
authorLeon Romanovsky <leonro@mellanox.com>
Sun, 19 Apr 2020 15:55:06 +0000 (18:55 +0300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 21 Apr 2020 20:27:37 +0000 (13:27 -0700)
commit51161bfc66a68d21f13d15a689b3ea7980457790
tree32af1a956fda40175af5dc2587670f8a79ac0abc
parentb4f37219813fd126b2cda6d7805d8c61b8cf801a
kernel/module: Hide vermagic header file from general use

VERMAGIC* definitions are not supposed to be used by the drivers,
see this [1] bug report, so introduce special define to guard inclusion
of this header file and define it in kernel/modules.h and in internal
script that generates *.mod.c files.

In-tree module build:
➜  kernel git:(vermagic) ✗ make clean
➜  kernel git:(vermagic) ✗ make M=drivers/infiniband/hw/mlx5
➜  kernel git:(vermagic) ✗ modinfo drivers/infiniband/hw/mlx5/mlx5_ib.ko
filename: /images/leonro/src/kernel/drivers/infiniband/hw/mlx5/mlx5_ib.ko
<...>
vermagic:       5.6.0+ SMP mod_unload modversions

Out-of-tree module build:
➜  mlx5 make -C /images/leonro/src/kernel clean M=/tmp/mlx5
➜  mlx5 make -C /images/leonro/src/kernel M=/tmp/mlx5
➜  mlx5 modinfo /tmp/mlx5/mlx5_ib.ko
filename:       /tmp/mlx5/mlx5_ib.ko
<...>
vermagic:       5.6.0+ SMP mod_unload modversions

[1] https://lore.kernel.org/lkml/20200411155623.GA22175@zn.tnic
Reported-by: Borislav Petkov <bp@suse.de>
Acked-by: Borislav Petkov <bp@suse.de>
Acked-by: Jessica Yu <jeyu@kernel.org>
Co-developed-by: Masahiro Yamada <masahiroy@kernel.org>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/vermagic.h
kernel/module.c
scripts/mod/modpost.c