]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
ext4: fix SEEK_HOLE/SEEK_DATA for blocksize < pagesize
authorJan Kara <jack@suse.cz>
Sat, 5 Aug 2017 21:43:24 +0000 (17:43 -0400)
committerThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Tue, 22 Aug 2017 09:58:11 +0000 (06:58 -0300)
commit51208da3e9ec1c8c44c235e12640e5b2df2332f9
tree1092c710107f353d22982226d0487cf3c893d5fc
parentad793751a6f9b72d7843f13a0d6fc2244cfed9f5
ext4: fix SEEK_HOLE/SEEK_DATA for blocksize < pagesize

BugLink: http://bugs.launchpad.net/bugs/1711526
commit fcf5ea10992fbac3c7473a1db33d56a139333cd1 upstream.

ext4_find_unwritten_pgoff() does not properly handle a situation when
starting index is in the middle of a page and blocksize < pagesize. The
following command shows the bug on filesystem with 1k blocksize:

  xfs_io -f -c "falloc 0 4k" \
            -c "pwrite 1k 1k" \
            -c "pwrite 3k 1k" \
            -c "seek -a -r 0" foo

In this example, neither lseek(fd, 1024, SEEK_HOLE) nor lseek(fd, 2048,
SEEK_DATA) will return the correct result.

Fix the problem by neglecting buffers in a page before starting offset.

Reported-by: Andreas Gruenbacher <agruenba@redhat.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
fs/ext4/file.c