]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
xhci: Fix false warning message about wrong bounce buffer write length
authorMathias Nyman <mathias.nyman@linux.intel.com>
Fri, 4 Oct 2019 11:59:26 +0000 (14:59 +0300)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 12 Nov 2019 18:04:31 +0000 (19:04 +0100)
commit5138d65c8c31e68828873a6bd2388a7adf4a4459
treeb778a65227b133c18171749e91d5821506c5f684
parenta724a1e2a43ee78fded5137ad72d690ff884fd8d
xhci: Fix false warning message about wrong bounce buffer write length

BugLink: https://bugs.launchpad.net/bugs/1850541
commit c03101ff4f74bb30679c1a03d551ecbef1024bf6 upstream.

The check printing out the "WARN Wrong bounce buffer write length:"
uses incorrect values when comparing bytes written from scatterlist
to bounce buffer. Actual copied lengths are fine.

The used seg->bounce_len will be set to equal new_buf_len a few lines later
in the code, but is incorrect when doing the comparison.

The patch which added this false warning was backported to 4.8+ kernels
so this should be backported as far as well.

Cc: <stable@vger.kernel.org> # v4.8+
Fixes: 597c56e372da ("xhci: update bounce buffer with correct sg num")
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Link: https://lore.kernel.org/r/1570190373-30684-2-git-send-email-mathias.nyman@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/usb/host/xhci-ring.c