]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
fix inode leaks on d_splice_alias() failure exits
authorAl Viro <viro@zeniv.linux.org.uk>
Thu, 23 Oct 2014 17:26:21 +0000 (13:26 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Fri, 24 Oct 2014 02:30:18 +0000 (22:30 -0400)
commit51486b900ee92856b977eacfc5bfbe6565028070
tree7212a9d040a00c87bf8480d6ad4195658c4eca52
parentf114040e3ea6e07372334ade75d1ee0775c355e1
fix inode leaks on d_splice_alias() failure exits

d_splice_alias() callers expect it to either stash the inode reference
into a new alias, or drop the inode reference.  That makes it possible
to just return d_splice_alias() result from ->lookup() instance, without
any extra housekeeping required.

Unfortunately, that should include the failure exits.  If d_splice_alias()
returns an error, it leaves the dentry it has been given negative and
thus it *must* drop the inode reference.  Easily fixed, but it goes way
back and will need backporting.

Cc: stable@vger.kernel.org
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/dcache.c