]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
nvme-tcp: fix kconfig dependency warning when !CRYPTO
authorNecip Fazil Yildiran <fazilyildiran@gmail.com>
Mon, 14 Sep 2020 15:01:21 +0000 (18:01 +0300)
committerStefan Bader <stefan.bader@canonical.com>
Mon, 9 Nov 2020 13:48:00 +0000 (14:48 +0100)
commit51750ff6958f959f29ac3017c303469a3d81f181
treed347d9103fa40385901171f59aad9ea2e720ec07
parente42126ec0a3786c638cc27aba6cb2c37b769ecf3
nvme-tcp: fix kconfig dependency warning when !CRYPTO

BugLink: https://bugs.launchpad.net/bugs/1900624
[ Upstream commit af5ad17854f96a6d3c9775e776bd01ab262672a1 ]

When NVME_TCP is enabled and CRYPTO is disabled, it results in the
following Kbuild warning:

WARNING: unmet direct dependencies detected for CRYPTO_CRC32C
  Depends on [n]: CRYPTO [=n]
  Selected by [y]:
  - NVME_TCP [=y] && INET [=y] && BLK_DEV_NVME [=y]

The reason is that NVME_TCP selects CRYPTO_CRC32C without depending on or
selecting CRYPTO while CRYPTO_CRC32C is subordinate to CRYPTO.

Honor the kconfig menu hierarchy to remove kconfig dependency warnings.

Fixes: 79fd751d61aa ("nvme: tcp: selects CRYPTO_CRC32C for nvme-tcp")
Signed-off-by: Necip Fazil Yildiran <fazilyildiran@gmail.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Ian May <ian.may@canonical.com>
drivers/nvme/host/Kconfig