]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
x86/tdx: Fix __noreturn build warning around __tdx_hypercall_failed()
authorKai Huang <kai.huang@intel.com>
Mon, 18 Sep 2023 04:18:58 +0000 (16:18 +1200)
committerIngo Molnar <mingo@kernel.org>
Mon, 18 Sep 2023 07:11:39 +0000 (09:11 +0200)
commit518755a7eeae77a399430eaf211a1e71f6b87d4a
tree2c519be146ca28774c264250025db9c399772d66
parent7b804135d4d1f0a2b9dda69c6303d3f2dcbe9d37
x86/tdx: Fix __noreturn build warning around __tdx_hypercall_failed()

LKP reported below build warning:

  vmlinux.o: warning: objtool: __tdx_hypercall+0x128: __tdx_hypercall_failed() is missing a __noreturn annotation

The __tdx_hypercall_failed() function definition already has __noreturn
annotation, but it turns out the __noreturn must be annotated to the
function declaration.

PeterZ explains:

  "FWIW, the reason being that...

   The point of noreturn is that the caller should know to stop generating
   code. For that the declaration needs the attribute, because call sites
   typically do not have access to the function definition in C."

Add __noreturn annotation to the declaration of __tdx_hypercall_failed()
to fix.  It's not a bad idea to document the __noreturn nature at the
definition site either, so keep the annotation at the definition.

Note <asm/shared/tdx.h> is also included by TDX related assembly files.
Include <linux/compiler_attributes.h> only in case of !__ASSEMBLY__
otherwise compiling assembly file would trigger build error.

Also, following the objtool documentation, add __tdx_hypercall_failed()
to "tools/objtool/noreturns.h".

Fixes: c641cfb5c157 ("x86/tdx: Make TDX_HYPERCALL asm similar to TDX_MODULE_CALL")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Kai Huang <kai.huang@intel.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20230918041858.331234-1-kai.huang@intel.com
Closes: https://lore.kernel.org/oe-kbuild-all/202309140828.9RdmlH2Z-lkp@intel.com/
arch/x86/include/asm/shared/tdx.h
tools/objtool/noreturns.h