]> git.proxmox.com Git - mirror_qemu.git/commit
hw/misc/ivshmem: Fix ivshmem_recv_msg() to also work on big endian systems
authorThomas Huth <thuth@redhat.com>
Wed, 30 Aug 2017 13:39:03 +0000 (15:39 +0200)
committerCornelia Huck <cohuck@redhat.com>
Tue, 19 Sep 2017 16:21:33 +0000 (18:21 +0200)
commit51af0ec9fa7269f0c69aa50a1a24748b4edc4b44
tree68f0ce22a478ebf25585569474429288728a6c9a
parent6c5e740247182807b684d30db20d9b8e169b5b22
hw/misc/ivshmem: Fix ivshmem_recv_msg() to also work on big endian systems

The "slow" ivshmem-tests currently fail when they are running on a
big endian host:

$ uname -m
ppc64
$ V=1 QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 tests/ivshmem-test -m slow
/x86_64/ivshmem/single: OK
/x86_64/ivshmem/hotplug: OK
/x86_64/ivshmem/memdev: OK
/x86_64/ivshmem/pair: OK
/x86_64/ivshmem/server-msi: qemu-system-x86_64:
 -device ivshmem-doorbell,chardev=chr0,vectors=2: server sent invalid ID message
Broken pipe

The problem is that the server side code in ivshmem_server_send_one_msg()
correctly translates all messages IDs into little endian 64-bit values,
but the client side code in the ivshmem_recv_msg() function does not swap
the byte order back. Fix it by passing the value through le64_to_cpu().

Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <1504100343-26607-1-git-send-email-thuth@redhat.com>
Tested-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
hw/misc/ivshmem.c