]> git.proxmox.com Git - mirror_qemu.git/commit
build: move COLO under CONFIG_REPLICATION
authorVladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Fri, 28 Apr 2023 19:49:21 +0000 (22:49 +0300)
committerJuan Quintela <quintela@redhat.com>
Wed, 10 May 2023 16:48:11 +0000 (18:48 +0200)
commit51e47cf8600dab5beedd7fa369ffd645868672ec
tree52208e5730399377b8cb2f247a7fe129da691515
parent4332ffcd7b21f7391fef1d916e1e3cd5b4bdd268
build: move COLO under CONFIG_REPLICATION

We don't allow to use x-colo capability when replication is not
configured. So, no reason to build COLO when replication is disabled,
it's unusable in this case.

Note also that the check in migrate_caps_check() is not the only
restriction: some functions in migration/colo.c will just abort if
called with not defined CONFIG_REPLICATION, for example:

    migration_iteration_finish()
       case MIGRATION_STATUS_COLO:
           migrate_start_colo_process()
               colo_process_checkpoint()
                   abort()

It could probably make sense to have possibility to enable COLO without
REPLICATION, but this requires deeper audit of colo & replication code,
which may be done later if needed.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Acked-by: Dr. David Alan Gilbert <dave@treblig.org>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Message-Id: <20230428194928.1426370-4-vsementsov@yandex-team.ru>
Signed-off-by: Juan Quintela <quintela@redhat.com>
hmp-commands.hx
migration/colo.c
migration/meson.build
migration/migration-hmp-cmds.c
migration/migration.c
qapi/migration.json
stubs/colo.c [new file with mode: 0644]
stubs/meson.build