]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
net: stmmac: dwmac-anarion: Always return struct anarion_gmac * from anarion_config_dt()
authorSimon Horman <horms@kernel.org>
Thu, 6 Apr 2023 17:30:10 +0000 (19:30 +0200)
committerJakub Kicinski <kuba@kernel.org>
Sat, 8 Apr 2023 03:06:04 +0000 (20:06 -0700)
commit51fe084b17e795f0315d787077510364172cc350
tree70dd8804a7aafb75d2a980e0305bb8376a4c68c1
parent9f12541d684b9250ed14bfca2cc1b106db1c0e74
net: stmmac: dwmac-anarion: Always return struct anarion_gmac * from anarion_config_dt()

Always return struct anarion_gmac * from anarion_config_dt().
In the case where ctl_block was an error pointer it was being
returned directly. Which sparse flags as follows:

 .../dwmac-anarion.c:73:24: warning: incorrect type in return expression (different address spaces)
 .../dwmac-anarion.c:73:24:    expected struct anarion_gmac *
 .../dwmac-anarion.c:73:24:    got void [noderef] __iomem *[assigned] ctl_block

Avoid this by converting the error pointer to an error.
And then reversing the conversion.

As a side effect, the error can be used for logging purposes,
subjectively, leading to a minor cleanup.

No functional change intended.
Compile tested only.

Signed-off-by: Simon Horman <horms@kernel.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c