]> git.proxmox.com Git - qemu.git/commit
main-loop: do not include slirp/slirp.h, use libslirp.h instead
authorMichael Tokarev <mjt@tls.msk.ru>
Wed, 12 Jun 2013 12:31:44 +0000 (16:31 +0400)
committerMichael Tokarev <mjt@tls.msk.ru>
Wed, 12 Jun 2013 14:43:08 +0000 (18:43 +0400)
commit520b6dd4d03742e285cc68cca308a2a74261c410
treed496a05dbfddb585477414f692fc91ad14b8b2c5
parent581fe784c3adf85dc167a47a4a60fd1245a98217
main-loop: do not include slirp/slirp.h, use libslirp.h instead

The header slirp/slirp.h is an internal header for slirp, and
main-loop.c does not use internals from there.  Instead, it uses
public functions (slirp_update_timeout(), slirp_pollfds_fill()
etc) which are declared in slirp/libslirp.h.

Including slirp/slirp.h is somewhat dangerous since it redefines
errno on WIN32, so any file including it may misbehave wrt errno.

Unfortunately libslirp isn't self-contained, it needs declaration
of struct in_addr, which is provided by qemu/sockets.h.  Maybe
instead of #including qemu/sockets.h before libslirp.h, it is
better to make the latter self-contained.

Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
main-loop.c