]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
PCI: designware: Remove incorrect io_base assignment
authorStanimir Varbanov <stanimir.varbanov@linaro.org>
Tue, 24 Nov 2015 09:36:52 +0000 (11:36 +0200)
committerBjorn Helgaas <bhelgaas@google.com>
Tue, 24 Nov 2015 20:06:41 +0000 (14:06 -0600)
commit5228e39e3f709c82e6c4643402fc25de54391e32
tree4c9ab4e1079907b3d6e97a0201bcb870d9bf62a9
parent3dcc8d39cf15fa3ceabedcffcbd3958fe953555a
PCI: designware: Remove incorrect io_base assignment

"pp->io" is an I/O resource, e.g., "[io 0x0000-0xffff]"; "pp->io_base" is
the CPU physical address of a region where the host bridge converts CPU
memory accesses into PCI I/O transactions.

Corrupting pp->io_base by assigning pp->io->start to it breaks access to
the PCI I/O space, as reported by Kishon.

Remove the invalid assignment.

[bhelgaas: changelog]
Fixes: 0021d22b73d6 ("PCI: designware: Use of_pci_get_host_bridge_resources() to parse DT")
Reported-and-tested-by: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
drivers/pci/host/pcie-designware.c