]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
lguest: example launcher to use guard pages, drop PROT_EXEC, fix limit logic
authorPhilip Sanderson <philip.k.sanderson@gmail.com>
Fri, 21 Jan 2011 03:37:28 +0000 (21:37 -0600)
committerRusty Russell <rusty@rustcorp.com.au>
Thu, 20 Jan 2011 11:07:29 +0000 (21:37 +1030)
commit5230ff0cccb0611830bb02b097535868df02752a
tree7d1345e1ede12e2fd85918c9944fe929017cde6b
parent8aeb36e8f6d7eaa9cafc970b700414205743b258
lguest: example launcher to use guard pages, drop PROT_EXEC, fix limit logic

PROT_EXEC seems to be completely unnecessary (as the lguest binary
never executes there), and will allow it to work with SELinux (and
more importantly, PaX :-) as they can/do forbid writable and
executable mappings.

Also, map PROT_NONE guard pages at start and end of guest memory for extra
paranoia.

I changed the length check to addr + size > guest_limit because >= is wrong
(addr of 0, size of getpagesize() with a guest_limit of getpagesize() would
false positive).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Documentation/lguest/lguest.c