]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
genirq: fix regression in irqfixup, irqpoll
authorEdward Donovan <edward.donovan@numble.net>
Mon, 28 Nov 2011 04:07:34 +0000 (23:07 -0500)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 28 Nov 2011 16:43:09 +0000 (08:43 -0800)
commit52553ddffad76ccf192d4dd9ce88d5818f57f62a
treec455a00601de4deeb4d9cc759e8b527ca574293a
parent401d0069cb344f401bc9d264c31db55876ff78c0
genirq: fix regression in irqfixup, irqpoll

Commit fa27271bc8d2("genirq: Fixup poll handling") introduced a
regression that broke irqfixup/irqpoll for some hardware configurations.

Amidst reorganizing 'try_one_irq', that patch removed a test that
checked for 'action->handler' returning IRQ_HANDLED, before acting on
the interrupt.  Restoring this test back returns the functionality lost
since 2.6.39.  In the current set of tests, after 'action' is set, it
must precede '!action->next' to take effect.

With this and my previous patch to irq/spurious.c, c75d720fca8a, all
IRQ regressions that I have encountered are fixed.

Signed-off-by: Edward Donovan <edward.donovan@numble.net>
Reported-and-tested-by: Rogério Brito <rbrito@ime.usp.br>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@kernel.org (2.6.39+)
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/irq/spurious.c