]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
IB/IPoIB: Add destination address when re-queue packet
authorErez Shitrit <erezsh@mellanox.com>
Wed, 1 Feb 2017 17:10:05 +0000 (19:10 +0200)
committerThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Thu, 6 Apr 2017 08:22:20 +0000 (09:22 +0100)
commit52567afcdbe9e9addc8cef14fcd6f14032db1716
tree9f923d71e508575ea04e411a803dd82e927f93e2
parentc121880bed2fb297b2998200ca22453f6372fb48
IB/IPoIB: Add destination address when re-queue packet

BugLink: http://bugs.launchpad.net/bugs/1673541
commit 2b0841766a898aba84630fb723989a77a9d3b4e6 upstream.

When sending packet to destination that was not resolved yet
via path query, the driver keeps the skb and tries to re-send it
again when the path is resolved.

But when re-sending via dev_queue_xmit the kernel doesn't call
to dev_hard_header, so IPoIB needs to keep 20 bytes in the skb
and to put the destination address inside them.

In that way the dev_start_xmit will have the correct destination,
and the driver won't take the destination from the skb->data, while
nothing exists there, which causes to packet be be dropped.

The test flow is:
1. Run the SM on remote node,
2. Restart the driver.
4. Ping some destination,
3. Observe that first ICMP request will be dropped.

Fixes: fc791b633515 ("IB/ipoib: move back IB LL address into the hard header")
Signed-off-by: Erez Shitrit <erezsh@mellanox.com>
Signed-off-by: Noa Osherovich <noaos@mellanox.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Tested-by: Yuval Shaia <yuval.shaia@oracle.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
drivers/infiniband/ulp/ipoib/ipoib_main.c