]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
spi: fsl-dspi: fix use-after-free in remove path
authorSascha Hauer <s.hauer@pengutronix.de>
Wed, 23 Sep 2020 13:10:26 +0000 (15:10 +0200)
committerMark Brown <broonie@kernel.org>
Wed, 23 Sep 2020 16:31:14 +0000 (17:31 +0100)
commit530b5affc675ade5db4a03f04ed7cd66806c8a1a
treed4070e5983f6f0416b7cc280bc9f44a405e360e9
parentb867eef4cf548cd9541225aadcdcee644669b9e1
spi: fsl-dspi: fix use-after-free in remove path

spi_unregister_controller() not only unregisters the controller, but
also frees the controller. This will free the driver data with it, so
we must not access it later dspi_remove().

Solve this by allocating the driver data separately from the SPI
controller.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Link: https://lore.kernel.org/r/20200923131026.20707-1-s.hauer@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-fsl-dspi.c