]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
sysctl: don't print negative flag for proc_douintvec
authorLiping Zhang <zlpnobody@gmail.com>
Fri, 7 Apr 2017 15:51:06 +0000 (23:51 +0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 7 Apr 2017 16:46:44 +0000 (09:46 -0700)
commit5380e5644afbba9e3d229c36771134976f05c91e
treeec273fa8b308ad2c7a0a3d1fa3cc8f8b092c602f
parent1680a3868f00be638a8a213a321e88d11ce7e9f7
sysctl: don't print negative flag for proc_douintvec

I saw some very confusing sysctl output on my system:
  # cat /proc/sys/net/core/xfrm_aevent_rseqth
  -2
  # cat /proc/sys/net/core/xfrm_aevent_etime
  -10
  # cat /proc/sys/net/ipv4/tcp_notsent_lowat
  -4294967295

Because we forget to set the *negp flag in proc_douintvec, so it will
become a garbage value.

Since the value related to proc_douintvec is always an unsigned integer,
so we can set *negp to false explictily to fix this issue.

Fixes: e7d316a02f68 ("sysctl: handle error writing UINT_MAX to u32 fields")
Signed-off-by: Liping Zhang <zlpnobody@gmail.com>
Cc: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
kernel/sysctl.c