]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
dmaengine: sh: rcar-dmac: avoid to write CHCR.TE to 1 if TCR is set to 0
authorYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Mon, 2 Jul 2018 09:18:03 +0000 (18:18 +0900)
committerVinod Koul <vkoul@kernel.org>
Tue, 10 Jul 2018 15:19:46 +0000 (20:49 +0530)
commit538603c6026ce769eec633bb79349f5f287519c7
treefb908a88e463a1890f9fb4e410c5d04bf7d87b49
parente919417bd6468b7f1b2899200a78f1ad078757d3
dmaengine: sh: rcar-dmac: avoid to write CHCR.TE to 1 if TCR is set to 0

This patch fixes an issue that unexpected retransfering happens
if TCR is set to 0 before rcar_dmac_sync_tcr() writes DE bit to
the CHCR register. For example, sh-sci driver can reproduce this
issue like below:

 In rx_timer_fn(): /* CHCR DE bit may be set to 1 */
  dmaengine_tx_status()
   rcar_dmac_tx_status()
    rcar_dmac_chan_get_residue()
     rcar_dmac_sync_tcr() /* TCR is possible to be set to 0 */

According to the description of commit 73a47bd0da66 ("dmaengine:
rcar-dmac: use TCRB instead of TCR for residue"), "this buffered data
will be transferred if CHCR::DE bit was cleared". So, this patch
doesn't need to check TCRB register.

Fixes: 73a47bd0da66 ("dmaengine: rcar-dmac: use TCRB instead of TCR for residue")
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/sh/rcar-dmac.c