]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
efi/x86: Fix build with gcc 4
authorArvind Sankar <nivedita@alum.mit.edu>
Fri, 5 Jun 2020 15:06:38 +0000 (11:06 -0400)
committerArd Biesheuvel <ardb@kernel.org>
Mon, 15 Jun 2020 09:41:14 +0000 (11:41 +0200)
commit5435f73d5c4a1b7504356876e69ba52de83f4975
treeda0e5d0171d77235b03b3ed6c8287689080a955d
parentb3a9e3b9622ae10064826dccb4f7a52bd88c7407
efi/x86: Fix build with gcc 4

Commit

  bbf8e8b0fe04 ("efi/libstub: Optimize for size instead of speed")

changed the optimization level for the EFI stub to -Os from -O2.

Andrey Ignatov reports that this breaks the build with gcc 4.8.5.

Testing on godbolt.org, the combination of -Os,
-fno-asynchronous-unwind-tables, and ms_abi functions doesn't work,
failing with the error:
  sorry, unimplemented: ms_abi attribute requires
  -maccumulate-outgoing-args or subtarget optimization implying it

This does appear to work with gcc 4.9 onwards.

Add -maccumulate-outgoing-args explicitly to unbreak the build with
pre-4.9 versions of gcc.

Reported-by: Andrey Ignatov <rdna@fb.com>
Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu>
Link: https://lore.kernel.org/r/20200605150638.1011637-1-nivedita@alum.mit.edu
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
drivers/firmware/efi/libstub/Makefile