]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
memstick: use sector_div instead of do_div
authorArnd Bergmann <arnd@arndb.de>
Wed, 20 Jan 2016 23:02:15 +0000 (15:02 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 21 Jan 2016 01:09:18 +0000 (17:09 -0800)
commit545b5e2ad4771d23d4c67d0bcc18babd2070df13
tree1266db263a455f969f7b3fa74366939547de722a
parent8e99469ab0f821bea77625cd4775ca529d4ca7d4
memstick: use sector_div instead of do_div

do_div is the wrong way to divide a sector_t, as it is less efficient
when sector_t is 32-bit wide.  With the upcoming do_div optimizations,
the kernel starts warning about this:

  drivers/memstick/core/ms_block.c: In function 'msb_io_work':
  include/asm-generic/div64.h:207:28: warning: comparison of distinct pointer types lacks a cast

This changes the code to use sector_div instead, which always produces
optimal code.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Maxim Levitsky <maximlevitsky@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/memstick/core/ms_block.c