]> git.proxmox.com Git - mirror_qemu.git/commit
spapr_events: Rewrite a fall through comment
authorPhilippe Mathieu-Daudé <philmd@redhat.com>
Fri, 19 Jul 2019 13:14:25 +0000 (15:14 +0200)
committerLaurent Vivier <laurent@vivier.eu>
Wed, 21 Aug 2019 08:59:10 +0000 (10:59 +0200)
commit54db89f5bbe5c12f238835aa94aa4b13ac22834d
treec134682a31559c4741008e8cbd9778c530fa7bfe
parent4e8de60623f49def9016b8174261e9ab84f79bb7
spapr_events: Rewrite a fall through comment

GCC9 is confused by this comment when building with CFLAG
-Wimplicit-fallthrough=2:

    CC      ppc64-softmmu/hw/ppc/spapr_rtc.o
  hw/ppc/spapr_events.c: In function ‘rtas_event_log_to_source’:
  hw/ppc/spapr_events.c:312:12: error: this statement may fall through [-Werror=implicit-fallthrough=]
    312 |         if (spapr_ovec_test(spapr->ov5_cas, OV5_HP_EVT)) {
        |            ^
  hw/ppc/spapr_events.c:317:5: note: here
    317 |     case RTAS_LOG_TYPE_EPOW:
        |     ^~~~
  cc1: all warnings being treated as errors

Rewrite the comment using 'fall through' which is recognized by
GCC and static analyzers.

Reported-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Message-Id: <20190719131425.10835-8-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
hw/ppc/spapr_events.c