]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
ping: remove pr_err from ping_lookup
authorXin Long <lucien.xin@gmail.com>
Thu, 24 Feb 2022 03:41:08 +0000 (22:41 -0500)
committerPaolo Pisati <paolo.pisati@canonical.com>
Mon, 7 Mar 2022 10:45:56 +0000 (11:45 +0100)
commit550201c5fb3e49867e1bcc8693ad96226232ef72
tree0b7fc03778ad7198649ddbadd2f0a2fe517f635a
parent3c6f38cf0469acb0d08d4df459c5dd239ebc3b25
ping: remove pr_err from ping_lookup

BugLink: https://bugs.launchpad.net/bugs/1963891
commit cd33bdcbead882c2e58fdb4a54a7bd75b610a452 upstream.

As Jakub noticed, prints should be avoided on the datapath.
Also, as packets would never come to the else branch in
ping_lookup(), remove pr_err() from ping_lookup().

Fixes: 35a79e64de29 ("ping: fix the dif and sdif check in ping_lookup")
Reported-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Link: https://lore.kernel.org/r/1ef3f2fcd31bd681a193b1fcf235eee1603819bd.1645674068.git.lucien.xin@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
net/ipv4/ping.c