]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
dm raid1: fail writes if errors are not handled and log fails
authorMikulas Patocka <mpatocka@redhat.com>
Tue, 16 Feb 2010 18:42:55 +0000 (18:42 +0000)
committerAlasdair G Kergon <agk@redhat.com>
Tue, 16 Feb 2010 18:42:55 +0000 (18:42 +0000)
commit5528d17de1cf1462f285c40ccaf8e0d0e4c64dc0
tree11c754019431e7561a629fb7d0b4378ef96b8e15
parentebfd32bba9b518d684009d9d21a56742337ca1b3
dm raid1: fail writes if errors are not handled and log fails

If the mirror log fails when the handle_errors option was not selected
and there is no remaining valid mirror leg, writes return success even
though they weren't actually written to any device.  This patch
completes them with EIO instead.

This code path is taken:
do_writes:
bio_list_merge(&ms->failures, &sync);
do_failures:
if (!get_valid_mirror(ms)) (false)
else if (errors_handled(ms)) (false)
else bio_endio(bio, 0);

The logic in do_failures is based on presuming that the write was already
tried: if it succeeded at least on one leg (without handle_errors) it
is reported as success.

Reference: https://bugzilla.redhat.com/show_bug.cgi?id=555197

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
drivers/md/dm-raid1.c